Skip to content

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Wireframe #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pretty548 wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Wireframe #1096

Pretty548 wants to merge 16 commits into from

Conversation

@Pretty548
Copy link

@Pretty548 Pretty548 commented Jan 30, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Used semantic HTML (header, main, section, article, footer)
  • Added page header with title and description
  • Created three articles with title, summary, and link
  • Added content explaining README, wireframes, and Git branches
  • Styled the page using an external CSS file
  • Fixed the footer to the bottom of the viewport
  • Matched layout to the provided wireframe
  • Achieved 100 Accessibility score in Lighthouse
  • Committed and pushed changes to feature/wireframe branch

Questions

How does using semantic HTML improve accessibility and the overall structure of a webpage?

@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@netlify
Copy link

netlify bot commented Jan 30, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8616498
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697d7bccf98a870008084a7f
😎 Deploy Preview https://deploy-preview-1096--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Pretty548 Pretty548 mentioned this pull request Jan 30, 2026
Open
@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
cjyuan
cjyuan reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page and code look good.

One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 30, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 4, 2026

Changes look good.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pretty548 @cjyuan @Luke-Manyamazi